New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide UI to work with versions and audit entries #108
Comments
I've updated the Some notes:
Two questions @auniverseaway : Just reveal them all when clicking on it? And how should we make visible the hidden audit log entries for previous dates? Similarly reveal them all when clicking on it? Any feedback appreciated 😄 |
I made a first attempt at naming versions. You can see it show up in the version list here beside the green circle. Right now I have a button to name the currently selected version in the toolbar but you probably want to change that 😉 @auniverseaway What UI interaction do you have in mind to enter the name for the version? (note that for this to work some pending changes to da-admin are needed) |
Yup, I think so. The idea I had was:
Which I think you basically already have, right?
I think if the transparent history pane can be as tall as the document, and if it's larger than the doc, there's an overflow-y. For the individual date overflow... maybe we don't try to clamp the height and see how bad things are from a noise perspective. |
With 6bd5447 I added expansion when clicking on it like this: After clicking on each hidden element: Obviously clicking on an expanded item again will hide it again. Hopefully this is close to what you had in mind. I think the colours when expanded are slightly different, but thats easy to change. Remaining question is how a version is named. The current implementation allows the naming of a selected version by clicking on this button And then entering the name in a popup dialog. I have the feeling you probably want to visualise that differently. Just let me know. |
With 544e834 I updated the version naming as follows: When a new version is created with the top button in the version toolbar an entry appears in the version line with a where the user can type in the version name (using When the user hits enter or clicks somewhere else on the screen, the version is stored in the backend. It's also still possible to select a version and edit the name or give it a name if it didn't have a name before via this button: If the user hits Escape the version creation/editing is cancelled. Note that this change needs adobe/da-admin#38 |
We need the UI to work with Versions adobe/da-admin#6 and Audit entries adobe/da-admin#5
The text was updated successfully, but these errors were encountered: