Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide UI to work with versions and audit entries #108

Open
bosschaert opened this issue Apr 17, 2024 · 6 comments
Open

Provide UI to work with versions and audit entries #108

bosschaert opened this issue Apr 17, 2024 · 6 comments
Assignees
Labels

Comments

@bosschaert
Copy link
Contributor

We need the UI to work with Versions adobe/da-admin#6 and Audit entries adobe/da-admin#5

@auniverseaway
Copy link
Member

Artboard 1

@bosschaert
Copy link
Contributor Author

bosschaert commented Apr 24, 2024

I've updated the versions branch to look like the artboard:
Screenshot 2024-04-24 at 12 34 35

Some notes:

  • I left the seconds on the timestamps, otherwise you'd get multiple timestamps for the same minute which doesn't look good IMHO.
  • I couldn't find the icons on https://spectrum.adobe.com/page/icons/ so I left the old ones for now...
  • Also note that there are no named versions yet.

Two questions @auniverseaway :
How would we expand the list of audit logs at the top that are overflowing and hidden?
Screenshot 2024-04-24 at 12 37 06

Just reveal them all when clicking on it?

And how should we make visible the hidden audit log entries for previous dates?
Screenshot 2024-04-24 at 12 37 10

Similarly reveal them all when clicking on it?

Any feedback appreciated 😄

@bosschaert
Copy link
Contributor Author

I made a first attempt at naming versions. You can see it show up in the version list here beside the green circle. Right now I have a button to name the currently selected version in the toolbar but you probably want to change that 😉
Screenshot 2024-04-26 at 14 12 09

@auniverseaway What UI interaction do you have in mind to enter the name for the version?

(note that for this to work some pending changes to da-admin are needed)

@auniverseaway
Copy link
Member

How would we expand the list of audit logs at the top that are overflowing and hidden?
Just reveal them all when clicking on it?

Yup, I think so. The idea I had was:

  1. Small filled gray - collapsed audit log for the day. - lighter text
  2. Medium filled green - version - darker text
  3. Expanded outline - opened audit log - medium dark text

Which I think you basically already have, right?

And how should we make visible the hidden audit log entries for previous dates?

I think if the transparent history pane can be as tall as the document, and if it's larger than the doc, there's an overflow-y.

For the individual date overflow... maybe we don't try to clamp the height and see how bad things are from a noise perspective.

@bosschaert
Copy link
Contributor Author

bosschaert commented Apr 29, 2024

Just reveal them all when clicking on it?

Yup, I think so.

With 6bd5447 I added expansion when clicking on it like this:

Initial visual:
Screenshot 2024-04-29 at 14 06 57

After clicking on each hidden element:
Screenshot 2024-04-29 at 14 07 06

Obviously clicking on an expanded item again will hide it again.

Hopefully this is close to what you had in mind. I think the colours when expanded are slightly different, but thats easy to change.

Remaining question is how a version is named. The current implementation allows the naming of a selected version by clicking on this button Screenshot 2024-04-29 at 14 20 51

And then entering the name in a popup dialog.
Screenshot 2024-04-29 at 14 21 19

I have the feeling you probably want to visualise that differently. Just let me know.

@bosschaert
Copy link
Contributor Author

bosschaert commented Apr 30, 2024

With 544e834 I updated the version naming as follows:

When a new version is created with the top button in the version toolbar an entry appears in the version line with a where the user can type in the version name (using contenteditable=true):
Screenshot 2024-04-30 at 16 00 11
Note that the date is already always stored, so the version name just defaults to some initial version text.

When the user hits enter or clicks somewhere else on the screen, the version is stored in the backend.
Screenshot 2024-04-30 at 16 24 46

It's also still possible to select a version and edit the name or give it a name if it didn't have a name before via this button:
Screenshot 2024-04-29 at 14 20 51
let me know if you want to keep that or not.

If the user hits Escape the version creation/editing is cancelled.

Note that this change needs adobe/da-admin#38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants