Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TypeScript for CoralUI #5

Open
3 of 4 tasks
Vishesh-Gupta opened this issue Nov 1, 2019 · 3 comments
Open
3 of 4 tasks

Support for TypeScript for CoralUI #5

Vishesh-Gupta opened this issue Nov 1, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@Vishesh-Gupta
Copy link

Type of Issue

  • Bug
  • Feature Request
  • Enhancement
  • Support for typescript

Current Behaviour

  • The coral-spectrum package only works with Javascript and does not support types at all for TypeScript

Requested Behaviour

  • To be able to work in Typescript by using types for CoralUI and include it in projects using React, Angular, or Vue.

Implementation

  • It could be implemented by adding an external package with types
  • Adding the types withing the coral-spectrum package.

Why requesting this feature?

  • To work with typescript based projects and including basic Coral-Spectrum from package registry does not work since the package does not have types defined.
  • Typescript is getting extremely popular in the community and it is being accepted by community with amazing love and support
  • Coral is an amazing minimal UI library. Being able to include it in TypeScript projects will help developers like me to include minimalistic UI components into our projects and promote CoralUI library
  • Makes the package more scalable and use with either a javascript/typescript project
@icaraps
Copy link
Contributor

icaraps commented Nov 1, 2019

@Vishesh-Gupta I'd propose to do a max of 5 components to start with and do the rest later if it's working fine. Do you have components in mind which should be done first ? I can think of Icon and Button for instance.

@Vishesh-Gupta
Copy link
Author

@icaraps Sure I'd be happy to work on it. Is there a slack channel the team uses to communicate on the development so that I can join and talk about my ideas there? I really like the library and would want to contribute to more things other than just the TypeScript definitions for it.

@icaraps
Copy link
Contributor

icaraps commented Nov 4, 2019

@Vishesh-Gupta it's an internal slack channel but feel free to expose your ideas here or in your PR :)

@icaraps icaraps added the enhancement New feature or request label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants