Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Masonry][Accessibility] Files: Main Navigation (Card View) - Selected state of the folder is not announced to the screen reader #249

Open
majornista opened this issue Oct 11, 2022 · 1 comment
Labels

Comments

@majornista
Copy link
Collaborator

majornista commented Oct 11, 2022

Expected Behavior

A screen reader should accurately announces the selected/unselected state of Masonry items, which in AEM will contain Card View items and folders.

Actual Behavior

A screen reader does not accurately announce the selected/unselected state of Masonry items, which in AEM will contain Card View items and folders.

Reproduce Scenario (including but not limited to)

https://opensource.adobe.com/coral-spectrum/examples/#masonry or any AEM UI using coral-masonry.

Steps to Reproduce

Described in ASSETS-6844

Browser name/version/os (ie Chrome Version 62.0.3202.94 (Official Build) (64-bit) MacOS)

Chrome Version 105.0.5195.125 (Official Build) (arm64) MacOS

Coral Spectrum version

v4.15.2

Possible solution

  1. Incorporate fix(#244): [Masonry][Accessibility] add aria-multiselectable to parent element with role="grid" #245 to ensure that the coral-masonry grid is identified as supporting selection using aria-multiselectable.
  2. Hide the coral-checkbox component using aria-hidden="true", so that while it provides a visual affordance for the selected state, the selected state for the item will be communicated to assistive technology using aria-selected on each of the cells.
  3. Ensure that aria-selected attribute is included on each masonry item, when selectionMode !== 'none'
  4. Ensure that the accessibilityState status message is not hidden on mac-like devices when the item is selected. This should ensure that the "Checked" state of an item is communicated by VoiceOver.
majornista added a commit to majornista/coral-spectrum that referenced this issue Oct 11, 2022
… View) - Selected state of the folder is not announced to the screen reader
majornista added a commit that referenced this issue Nov 2, 2022
…) - Selected state of the folder is not announced to the screen reader (#250)

* fix(#244): [Masonry][Accessibility] add aria-multiselectable to parent element with role="grid"

* fix(#249): [Masonry][Accessibility] Files: Main Navigation (Card View) - Selected state of the folder is not announced to the screen reader
github-actions bot pushed a commit that referenced this issue Nov 2, 2022
## [4.15.6](v4.15.5...v4.15.6) (2022-11-02)

### Bug Fixes

* **#249:** [Masonry][Accessibility] Files: Main Navigation (Card View) - Selected state of the folder is not announced to the screen reader ([#250](#250)) ([ff33df1](ff33df1)), closes [#249](#249) [#244](#244) [#249](#249)
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

🎉 This issue has been resolved in version 4.15.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant