Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect calling of another plugin/command #701

Open
purplecabbage opened this issue Jul 25, 2023 · 1 comment
Open

Incorrect calling of another plugin/command #701

purplecabbage opened this issue Jul 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@purplecabbage
Copy link
Member

purplecabbage commented Jul 25, 2023

https://github.com/adobe/aio-cli-plugin-app/blame/251f7bb62424d52d9eef307a161d28b3ddcc9d9f/src/commands/app/pack.js#L139

I missed this when it was committed, but this is not how we should call other commands in the app-plugin.

The proper way to do this is here:

const CertCmd = this.config.findCommand('certificate:generate')
if (CertCmd) {
const Instance = await CertCmd.load()
await Instance.run([`--keyout=${PRIVATE_KEY_PATH}`, `--out=${PUB_CERT_PATH}`, '-n=DeveloperSelfSigned.cert'])

@shazron shazron added the bug Something isn't working label Oct 4, 2023
@aiojbot
Copy link
Collaborator

aiojbot commented Oct 4, 2023

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants