Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in tests #668

Open
purplecabbage opened this issue May 6, 2023 · 1 comment
Open

Errors in tests #668

purplecabbage opened this issue May 6, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@purplecabbage
Copy link
Member

There are a bunch of cases where we mock command.error using command.error = jest.fn()
The oclif behavior of command.error is to exit, however our mock simply swallows the error and continues. This means we have a whole bunch of places where we are testing for arguments and calls to functions that should never have happened because command.error should have exited.

Simply removing the mock in deploy.test.js reveals 38 errors, which are all invalid tests and need to be written.

@purplecabbage purplecabbage added the bug Something isn't working label May 6, 2023
@aiojbot
Copy link
Collaborator

aiojbot commented May 6, 2023

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants