Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config files (.aio, .env) not available to templates for the "no login" case #657

Open
shazron opened this issue Apr 17, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@shazron
Copy link
Member

shazron commented Apr 17, 2023

Description

As you can see here, the config is only imported after the templates are installed here, for the "no login" case:

await this.installTemplates({
useDefaultValues: flags.yes,
installNpm: flags.install,
installConfig: flags.login,
templates
})
// 5. import config - if any
if (flags.import) {
await this.importConsoleConfig(consoleConfig)

For the "logged in" case, the templates are installed after the console config is imported:

await this.importConsoleConfig(consoleConfig)
// 9. install templates
await this.installTemplates({
useDefaultValues: flags.yes,
installNpm: flags.install,
templates
})

We should be consistent in both cases.

The Fix

Import the console config (if available via flag for the no login case), before templates are installed.

Code affected:

await this.installTemplates({
useDefaultValues: flags.yes,
installNpm: flags.install,
installConfig: flags.login,
templates
})
// 5. import config - if any
if (flags.import) {
await this.importConsoleConfig(consoleConfig)

@shazron shazron added the bug Something isn't working label Apr 17, 2023
@aiojbot
Copy link
Collaborator

aiojbot commented Apr 17, 2023

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants