Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent variable usage #608

Open
purplecabbage opened this issue Oct 27, 2022 · 1 comment
Open

Inconsistent variable usage #608

purplecabbage opened this issue Oct 27, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@purplecabbage
Copy link
Member

There is a var passed around called filterEntities that is used to filter what actions are to be deployed because they have changed.

Sometimes it is a Boolean: true, sometimes it is undefined, and sometimes it is an Object with a property actions which is an Array of actionNames ...

{ filterEntities: { actions: [ 'say-hello' ] } }

We need to be diligent about the types of objects we use, and they should never change.
@purplecabbage purplecabbage mentioned this issue Oct 28, 2022
Merged
10 tasks
@shazron shazron added the bug Something isn't working label Feb 15, 2023
@aiojbot
Copy link
Collaborator

aiojbot commented Feb 16, 2023

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shazron @purplecabbage @aiojbot