New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Broken aria-controls HTML attribute for tabs #2508

Open

rubnig opened this issue May 23, 2023 · 0 comments · May be fixed by #2509

rubnig commented May 23, 2023 •

edited

Bug Report

Current Behavior
In the tabs component, the tabs are having an aria-controls attribute to non existing tabpanel ids.

https://www.aemcomponents.dev/content/core-components-examples/library/core-content/tabs.html#tabs-763e4cccf7-item-c2ef7f1373-tab

This was previously fixed in 7f6bccd but undone in a4418ab#diff-627127c7d1ba22e049979452be71704e9d62b7534455397e778e364e804ece1eR41

Expected behavior/code
aria-controls HTML attribute should point to existing tab panels

Environment

AEMaaCS 2023.5.11983.20230511T173830Z-230200
Core Components version 2.22.10
Oracle JDK 11.0.19

Possible Solution
PR: #2509

The text was updated successfully, but these errors were encountered:

rubnig linked a pull request

that will close this issue

[2588] Fix aria-controls label for tabs component #2509

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment