Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links with Adobe Campaign scriptles are not externalized #2387

Open
Buuhuu opened this issue Nov 25, 2022 · 0 comments · May be fixed by #2388
Open

Links with Adobe Campaign scriptles are not externalized #2387

Buuhuu opened this issue Nov 25, 2022 · 0 comments · May be fixed by #2388

Comments

@Buuhuu
Copy link
Collaborator

Buuhuu commented Nov 25, 2022

Bug Report

Current Behavior
When a link uses adobe campaign scriptlets the externaliser fails with an exception:

25.11.2022 10:34:09.959 *ERROR* [[0:0:0:0:0:0:0:1] [1669368834327] GET /content/campaigns/core-email-components-examples/master/e-mail-campaign/e-maill-page.campaign.content.json HTTP/1.1] com.adobe.cq.wcm.core.
components.internal.link.DefaultPathProcessor error
java.lang.IllegalArgumentException: Illegal character in query at index 82: /content/campaigns/core-email-components-examples/master/e-mail-campaign.html?foo=<%= targetData.link %>
        at java.base/java.net.URI.create(URI.java:883)
        at com.day.cq.commons.impl.ExternalizerImpl.externalLink(ExternalizerImpl.java:324) [com.day.cq.cq-commons:5.12.16]
        at com.day.cq.commons.impl.ExternalizerImpl.publishLink(ExternalizerImpl.java:358) [com.day.cq.cq-commons:5.12.16]
        at com.adobe.cq.wcm.core.components.internal.link.DefaultPathProcessor.externalize(DefaultPathProcessor.java:164) [com.adobe.cq.core.wcm.components.core:2.21.0]

Expected behavior/code
Externalization should work

Environment

  • AEM version and patch level (e.g. AEM 6.5 SP16 load1)
  • Core Components version (e.g. 2.21.0)
  • JRE version (e.g. Java(TM) SE Runtime Environment (build 1.8.0_152-b16))

Possible Solution
Adobe Campaign scriptlets should be masked before passing the link to the externalizer.
@Buuhuu Buuhuu linked a pull request Nov 25, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: externalize links fails with ac scriptlets Buuhuu/aem-core-wcm-components
1 participant
@Buuhuu