New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Container] Create a Container v2 with the correct JSON output #1407
Comments
@stefanseifert I really wanted to have the exact JSON model like you mentioned here. I tried to implement the changes based on your PR. But now it is breaking the responsive layout, because the responsive layout component properties(columnClassNames, columnCount, gridClassNames) are missing. Is there any way to include these as well in addition to container properties? |
Hi, I also come across this problem on a work project and until last night couldn't see a solid path forward without reimplementing lots of private code. However, I stumbled upon Last night I worked on this and found a way to maintain the responsive grid properties while allowing for custom properties to be available in the model output. The link below shows how the model needs to be structured. There are 3 important things happening in my approach:
Essentially, what I have achieved with this approach is backwards compatibility with AEM's responsive grid while ensuring Sling Delegation remains functional with
Update for SPA: I have found a solution that ensures both normal and AEM SPA use remain functional. |
@adobe export issue to Jira project SITES as Story |
✅ Jira issue SITES-3332 is successfully created for this GitHub issue. |
…ped in model.json Export - add the ResponsivGrid specific fields to the model JSON output when the responsiveGrid layout is used
The JSON should be as follows for a simple container:
I see following options how the JSON should look like for a responsive grid container? Option#1:
Option#2:
IMHO option#1 makes the most sense as it has the basic properties of a simple container and adds the responsive grid specific properties. |
After discussing with our team, we decided to:
Simple Container:
Responsive Container:
|
…ped in model.json Export - exclude Allowed Components from the JSON output
Following code can be used as a starting point: |
The JSON output of the Container v1 looks as follows (as it inherits from the Responsive Grid component JSON):
The text was updated successfully, but these errors were encountered: