-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Transaction deduplication happens even if transactions have different imported_id
s
#2562
Closed
2 tasks done
Labels
Comments
MatissJanis
added
help wanted
Extra attention is needed
transaction import
Related to manually importing transactions
labels
Apr 7, 2024
Currently investigating this |
ttlgeek
added a commit
to ttlgeek/actual
that referenced
this issue
Apr 16, 2024
strazto
added a commit
to strazto/actual
that referenced
this issue
May 17, 2024
…n being imported is null
strazto
added a commit
to strazto/actual
that referenced
this issue
May 17, 2024
…n being imported is null
youngcw
pushed a commit
that referenced
this issue
Jun 7, 2024
…ns (#2770) * fix(#2562): Prevent transaction deduplication for imported transactions * chore(): eslint fixes * chore(): Add release note file * fix(#2562): Allow transaction deduplication if transaction being imported is null * chore: Rename release note, add strazto as author * test(loot-core): Add test case for new logic * docs(release-notes.loot-core): Add pmoon00 as author * test(loot-core): Update test case to not be affected by unrelated bug * test(loot-core): fix linter --------- Co-authored-by: Mohamed El Mahdali <mohamed.elmahdali.developer@gmail.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Verified issue does not already exist?
What happened?
I'm using a custom script to add transaction to Actual. The script uses the
importTransactions
function of the actual API. If I import two "similar" transactions, albeit with differentimport_id
s, Actual's deduplication function merges the two transactions even if it should not.As an example, I imported the following transaction:
Import was successful and the transaction appeared on Actual. Then, I imported the following transaction, which differs in
date
andimported_id
, but has the same amount and other properties of the previous one:The second import was also successful, but the transaction did not get added to Actual. Instead, the date of the first transaction got updated to match the second one (or the second transaction was added and the first disappeared, depending on how you want to see it).
As a sanity check, I changed the amount and tried importing the transaction again (with a fresh
imported_id
):This time, a separate transaction was added to Actual.
This behavior suggests that the deduplication feature does not take different
imported_id
s into account, while it should to avoid unintentionally merging different transactions.This issue was previously discussed on Discord.
Where are you hosting Actual?
Docker
What browsers are you seeing the problem on?
Firefox
Operating System
Mac OSX
The text was updated successfully, but these errors were encountered: