Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design LTN tool - turn restriction editing: testing with complicated_turn_restictions required #1113

Open
andrewphilipsmith opened this issue Sep 6, 2023 · 5 comments
Labels
good first issue Good for newcomers ltn

Comments

@andrewphilipsmith
Copy link
Collaborator

Current behaviour

The LTN turn restriction display and editing features have had limited testing with complicated_turn_restictions. Hence the behaviour may be unspecified and counterintuitive.

Suggesting improvement

Add systematic tests that cover a meaningful range of scenarios involving complicated_turn_restictions.

@iakev
Copy link

iakev commented Oct 4, 2023

Hi, I would like to take this issue up. As a beginner in Rust I believe this is a good opportunity for me. Kindly let me know.

@Zireael07
Copy link

Are you sure you understood what this issue entails? This is less about programming, more about design and testing (and automated testing in Rust is very much NOT a beginner thing)

@iakev
Copy link

iakev commented Oct 4, 2023

Ooh, okay am currently working through the Rust Book and am on automation. With a little guidance I can try my hand. Ithought it was a good first issue. However, I see your point and admittedly I have not really looked into the issue in-depth,so let me leave it then.

@dabreegster
Copy link
Collaborator

Hi @iakev, feel free to take on this issue if it's interesting! But I would agree it's maybe a bit tougher to start with. If you wanted something much more focused -- without any UI code to wrangle with particularly -- I might suggest a-b-street/osm2streets#222, if you have any interest in OpenStreetMap data. That issue requires some OSM domain knowledge, but we can also break down some steps if it's useful, so you could focus on the Rust part. It's a very easily unit testable issue, which is why it might be nice to start with.

@iakev
Copy link

iakev commented Oct 4, 2023

Hello @dabreegster, I believe that this issue might be a bit complex for me. Let me take your advice and look at the highlighted issue. Thanks for your guidance and suggestions. Thanks @Zireael07 for your concern also.

@dabreegster dabreegster added the ltn label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ltn
Projects
None yet
Development

No branches or pull requests

4 participants