Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most Microsoft domains not in popular domains #30

Open
hashimaziz1 opened this issue Sep 10, 2023 · 0 comments
Open

Most Microsoft domains not in popular domains #30

hashimaziz1 opened this issue Sep 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@hashimaziz1
Copy link
Contributor

Firstly, thanks for taking up the mantle since the death of mailcheck.js and for building a package that is generally a pleasure to set up and use out of the box.

I had a look at the default config for the list of domains:

const DEFAULT_CONFIG = {
  domainThreshold: 2,
  domains: POPULAR_DOMAINS,

  secondLevelThreshold: 2,
  secondLevelDomains: ['yahoo', 'hotmail', 'mail', 'live', 'outlook'],

  topLevelThreshold: 2,
  topLevelDomains: POPULAR_TLDS,

  distanceFunction: sift3Distance,
};

...and I'm a bit confused as to why Outlook/Hotmail/Mail/Live and Yahoo domains are separate from the popular domains list, which both Gmail.com, Googlemail.com and even MSN.com are on. At first I was going to make a PR to fix since it seems so much like a mistake, given the market share of all these domains is about the same as Gmail in the Western world, and sometimes higher for certain demographics (people who are Gen X or older, people in the UK) based on my experiences running a general purpose web app in the UK and seeing these domains on an hourly basis.

However I'm also not entirely sure what the purpose of the secondLevelDomains is, since the name is confusing (since most of the domains in popular domains are also second-level domains), and its function doesn't seem to be documented. Does secondLevelDomains function as a sort of lower priority list of domains, so that if there's a conflict popularDomains takes precedence? If not, what exactly is the purpose of secondLevelDomains, and do I have permission to move these domains into popularDomains where they should really belong?

@hashimaziz1 hashimaziz1 added the enhancement New feature or request label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant