Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data structure problem in feature molecular details #193

Open
sibyl229 opened this issue Feb 7, 2019 · 0 comments
Open

data structure problem in feature molecular details #193

sibyl229 opened this issue Feb 7, 2019 · 0 comments
Assignees
Labels

Comments

@sibyl229
Copy link
Contributor

sibyl229 commented Feb 7, 2019

Hi @a8wright in the d2c implementation for feature molecular details, the sequence_context.data.sequences attribute returns an array for some features and an object for other features. This isn't a good practice, as it easily confuses anything program that consumes the API.

Test case:
The following should return the same data structure, currently they are different:

  • /rest/widget/feature/WBsf019129/molecular_details
  • /rest/widget/feature/WBsf000519/molecular_details

Possible changes:

  • Always return the sequence and flanks on the proper strand (and only that strand), in which case you can always use the "array implementation", OR
  • Always return the sequence and flanks on both strands and indicate the default strand, in which case you can always use the "object implementation", OR
  • Some other data structure that you think is appropriate and is consistent across all features.

relates to and blocks(!!!) feature: WormBase/website#6871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants