Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles of selected item and apply action in multiple selection flow #601

Closed
fcoveram opened this issue Apr 17, 2024 · 2 comments
Closed
Assignees

Comments

@fcoveram
Copy link
Collaborator

The design shared for multiple-selection filter in pattern-directory#648 works correctly in Showcase. However, two styles are different than the designs.

Filter applied

The style of the item selected shows a grey background that was thought only for the hover state.

Apply button

After applying multiple filters, the popover in the search results page show the "Apply" button in its active style. Clicking on it does nothing

Here are images of current Showcase and design that work for both points.

Screenshot from Showcase Mockup from the design file
@ryelle
Copy link
Contributor

ryelle commented Apr 17, 2024

Apply button

We can't conditionally disable/enable Apply, because we don't track the selections that way. There's no way to differentiate between 3 items already selected, vs 2 already selected + 1 new — they're all just selected or not.

(mentioned in the PR #596)

Filter applied

Okay, I can remove that from active 👍🏻 On both multi and single selects, right?

@fcoveram
Copy link
Collaborator Author

We can't conditionally disable/enable Apply, because we don't track the selections that way.

Oh right. You already mentioned that before. Sorry.

Okay, I can remove that from active 👍🏻 On both multi and single selects, right?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants