Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the Jobs link to the footer #134

Open
aurooba opened this issue Feb 1, 2022 · 1 comment · May be fixed by #319
Open

Adding the Jobs link to the footer #134

aurooba opened this issue Feb 1, 2022 · 1 comment · May be fixed by #319
Labels
[Type] Enhancement New feature or request [Type] Question Further information is requested
Milestone
News: Post-launch...

Comments

@aurooba
Copy link
Member

aurooba commented Feb 1, 2022 •
edited

Hallo!

@courtneyr-dev opened this trac ticket to add a Jobs link in the global footer. I think this is a great idea. I'm aware that adding an additional link would throw the footer aesthetic off balance a bit but I've been exploring an option to make it look right and still be able to add that additional helpful link:
Screen Shot 2022-02-01 at 12 34 40 PM

Here we've added a Jobs link in the first column, Mobile in the second, Photos in the third, and Openverse in the fourth.

It's a pretty easy fix and I'm happy to take care of it, once there's agreement from all the right folks! Let me know. :)
@iandunn iandunn added [Type] Enhancement New feature or request [Type] Question Further information is requested labels Feb 11, 2022
@iandunn iandunn added this to the News: Post-launch iteration 1 milestone Feb 11, 2022
@coffee2code coffee2code mentioned this issue Jan 10, 2023
Closed
coffee2code added a commit to coffee2code/wporg-mu-plugins that referenced this issue Jan 11, 2023
@coffee2code
Footer: Add links to Mobile, Photos, Openverse, and Job Board
58d0ce4 
Fixes WordPress#134.
@coffee2code
Copy link
Contributor

Via #318, a Swag link was added to the first column of the global footer.

As I mentioned in that ticket, I am also in favor of the proposal here with a couple of minor changes:

  1. It looks like at the time Mobile was present and Learn wasn't, but that has since changed. Not sure if it should be reintroduced, but I'm assuming there's no harm in doing so to maintain balance across the footer columns. Also, Mobile is a link in the global nav menu, so it's not otherwise being obscured.
  2. For consistency with the global nav menu, the link should be Job Board instead of Jobs.
  3. As the Swag link was added to the first column (the one that was the most conceptually appropriate), the Job Board link should instead go into the last column. This seems more appropriate for that link anyhow.

134-footer

PR incoming.

@coffee2code coffee2code linked a pull request Jan 11, 2023 that will close this issue
Open
coffee2code added a commit to coffee2code/wporg-mu-plugins that referenced this issue Feb 27, 2023
@coffee2code
Footer: Add links to Mobile, Photos, Openverse, and Job Board
11a8ccd 
Fixes WordPress#134.
coffee2code added a commit to coffee2code/wporg-mu-plugins that referenced this issue Feb 27, 2023
@coffee2code
Footer: Add links to Mobile, Photos, Openverse, and Job Board
86562d3 
Fixes WordPress#134.
@coffee2code coffee2code mentioned this issue Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Enhancement New feature or request [Type] Question Further information is requested
Projects
None yet
Milestone
News: Post-launch iteration 2
Development

Successfully merging a pull request may close this issue.

Footer: Add links to Mobile, Photos, Openverse, and Job Board coffee2code/wporg-mu-plugins
3 participants
@iandunn @coffee2code @aurooba