Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login/Register links, move to secondary navigation, remove adminbar #420

Open
jasmussen opened this issue Apr 5, 2024 · 4 comments
Open
Labels
[Type] Enhancement New feature or request

Comments

@jasmussen
Copy link

Doing a quick review of navigating across all sections of WordPress.org this morning, and noticing a jump in the top navigation for every page that shows the adminbar. It seems that in every case where the adminbar shows, it exists to surface the login and register links. Here are pages that show the adminbar for this reason.

News:

news

Themes:

themes

Plugins:

plugins

Patterns:

patterns

Learn:

learn

Forums:

forums

Make (both landing and all P2s):

make

Photos:

photos

FFTF:

fftf

Also for reference, when you click "Log In" you see this page:

login

When you click "Register" you see this page:

register

In all these cases, those login/register links exist in context of those pages either being editable by contributors, or places where people can submit themes patterns, or otherwise. Those are all page-contextual actions, however, which suggest hierarchically those links should exist in context of the page, rather than in context of the site as they do when they are the first thing on the page.

Outside of fixing the hierarchy, addressing the jump is especially important on mobile, where those buttons get extra prominence and height:

mobile news

Suggestions

  • Can we remove the log-in links and adminbar from Five for the Future? It's not clear why it needs to be there at all.
  • Move all login and register links into a secondary navigation bar.

Mockup showing a single unified Log in/Register link:

login register links

This single link leans into #241, which puts a "Register" link right on the login page that'll take you there:
login-register-page

@jasmussen jasmussen added the [Type] Enhancement New feature or request label Apr 5, 2024
@dd32
Copy link
Member

dd32 commented Apr 5, 2024

Can we remove the log-in links and adminbar from Five for the Future? It's not clear why it needs to be there at all.

Done. It's there because it's primarily for logged in users, as that's how you manage your pledge - but if you don't know how to login, probably not actively contributing.

@jasmussen
Copy link
Author

Ah good note. To clarify, if you are logged in it's okay to show the adminbar across all sections. And in fact ideally we show it across all sections if you're logged in, so you don't get an inverse jump in that case of the adminbar disappearing.

@tobifjellner
Copy link

Is showing menu items like "my favorites" for not logged-in visitors desirable?

@jasmussen
Copy link
Author

Is showing menu items like "my favorites" for not logged-in visitors desirable?

I'd think so, yes, it makes clear a benefit you get from logging in. Besides, clicking Favorites if logged in, would take you to a screen prompting you to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants