Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favicon to Django API #4341

Closed
sarayourfriend opened this issue May 15, 2024 · 3 comments · Fixed by #4360
Closed

Add favicon to Django API #4341

sarayourfriend opened this issue May 15, 2024 · 3 comments · Fixed by #4360
Assignees
@madewithkode
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API

Comments

@sarayourfriend
Copy link
Contributor

sarayourfriend commented May 15, 2024 •
edited

Problem

The API has no favicon.

Description

We should add a favicon to the API.

Alternatives

Don't add a favicon. But why miss out on another opportunity to use @fcoveram's awesome Openverse logo?

Additional context

Use the favicon from #903 (comment)
@sarayourfriend sarayourfriend added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature labels May 15, 2024
@fcoveram
Copy link
Contributor

Awesome. Sharing the link that takes you to all SVG favicons.

@sarayourfriend sarayourfriend changed the title Add favicon to jango API Add favicon to Django API May 16, 2024
@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: api Related to the Django API and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels May 16, 2024
@dhruvkb
Copy link
Member

dhruvkb commented May 16, 2024 •
edited

If there is a plan of action on how this can be implemented, it seems like it could become a good-first-issue.

@madewithkode
Copy link
Contributor

I'd love to take on this :)

@madewithkode madewithkode mentioned this issue May 19, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madewithkode madewithkode

Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API
Projects
Openverse Backlog
Status: 🏗 In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add favicon to Django API madewithkode/openverse
4 participants
@fcoveram @dhruvkb @sarayourfriend @madewithkode