Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspect ratio preset names are not translatable #61767

Closed
swissspidy opened this issue May 17, 2024 · 0 comments 路 Fixed by #61774
Closed

Aspect ratio preset names are not translatable #61767

swissspidy opened this issue May 17, 2024 · 0 comments 路 Fixed by #61774
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@swissspidy
Copy link
Member

Description

Once again nobody thinks about internationalization... 馃槥

#47271 added support for aspect ratio presets via theme.json. Unfortunately those presets are not translatable.

Support needs to be added to theme-i18n.json, then once the feature is stable the schema needs to be updated on the CDN as well.

In the UI, the presets need to run through the translation function so that they can be correctly translated.

Step-by-step reproduction instructions

  1. Add aspect ratio presets to theme.json
  2. Change your language
  3. Wonder how you could translate the preset names

Screenshots, screen recording, code snippet

No response

Environment info

  • Current Gutenberg RC

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@swissspidy swissspidy added the [Type] Bug An existing feature does not function as intended label May 17, 2024
@swissspidy swissspidy mentioned this issue May 17, 2024
Merged
@Mamaduka Mamaduka added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label May 17, 2024
@fabiankaegy fabiankaegy mentioned this issue May 18, 2024
Merged
@fabiankaegy fabiankaegy linked a pull request May 18, 2024 that will close this issue
fix make dimensions.aspectRatios key of theme.json files translatable #61774
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix make dimensions.aspectRatios key of theme.json files translatable WordPress/gutenberg
2 participants
@Mamaduka @swissspidy