Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll Bar present in styles colors preset panel #61759

Closed
hbhalodia opened this issue May 17, 2024 · 5 comments · Fixed by #61617
Closed

Scroll Bar present in styles colors preset panel #61759

hbhalodia opened this issue May 17, 2024 · 5 comments · Fixed by #61617
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@hbhalodia
Copy link
Contributor

hbhalodia commented May 17, 2024

Description

On the Site Editor, if we visit the styles panel and open the colors panel, we can see that there is a scroll bar present in the color presets options pill.

Step-by-step reproduction instructions

  1. Open Site Editor.
  2. Go to styles > colors > pallets > presets
  3. You can see that there is the little scroll bar present in the pill that shows the color presets.

Screenshots, screen recording, code snippet

Screenshot 2024-05-17 at 4 32 21 PM

Screencast to reproduce the issue

GB.New.Issue.webm

Environment info

  • WordPress Version - 6.5.3
  • Gutenberg Version - Latest Trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@hbhalodia hbhalodia added the [Type] Bug An existing feature does not function as intended label May 17, 2024
@hbhalodia
Copy link
Contributor Author

There is an issue because IFrame is getting the height of 152px, which is the normalized height defined here.

Screenshot 2024-05-17 at 4 44 48 PM

We need to tweak this in order to fix the scrollbar issue.

@bgardner
Copy link

This looks like it was ack’ed #61617 by @youknowriad (#61617 (comment)) and confirmed by @annezazu (#61617 (comment)).

@annezazu
Copy link
Contributor

Yes! Hopefully, we can get that fixed within that PR. Thanks for sleuthing and dot connecting here.

@jordesign jordesign added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label May 20, 2024
@hbhalodia
Copy link
Contributor Author

Hi @fabiankaegy, I guess we can move this issue to Needs Review status, Since PR is already raised here - #61617 and looks like the potential fix for this.

Thank You ✨.

@fabiankaegy
Copy link
Member

Good call :) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants