Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font licenses are no longer automated with new Core Font Library functionality #525

Closed
mikachan opened this issue Mar 20, 2024 · 2 comments · Fixed by #649
Closed

Font licenses are no longer automated with new Core Font Library functionality #525

mikachan opened this issue Mar 20, 2024 · 2 comments · Fixed by #649
Assignees
@matiasbenedetto
Labels
bug Something isn't working

Comments

@mikachan
Copy link
Member

Part of replacing the integrated font management with the new Font LIbrary in Core means that we're losing the automated font license functionality provided by this plugin.

This is currently handled with the manage_font_license() function, included here.

Perhaps this could be added as a follow-up to #518 and #519.
@mikachan mikachan added the bug Something isn't working label Apr 12, 2024
@matiasbenedetto matiasbenedetto self-assigned this Apr 30, 2024
@matiasbenedetto matiasbenedetto mentioned this issue May 10, 2024
Merged
@matiasbenedetto
Copy link
Contributor

I'm working on a fix for this. I will submit the PR once this work gets merged: #626

This was referenced May 22, 2024
Merged
Merged
Merged
Merged
@pbking pbking linked a pull request May 30, 2024 that will close this issue
Handle font licenses when editing theme metadata #649
Merged
@pbking
Copy link
Contributor

pbking commented May 30, 2024

Fixed with #649
Closing

@pbking pbking closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matiasbenedetto matiasbenedetto

Labels
bug Something isn't working
Projects
Create Block Theme Release Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle font licenses when editing theme metadata WordPress/create-block-theme
3 participants
@pbking @matiasbenedetto @mikachan