Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend wasi_logging plugin to support log file #3399

Closed
apepkuss opened this issue May 13, 2024 · 5 comments
Closed

feat: extend wasi_logging plugin to support log file #3399

apepkuss opened this issue May 13, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@apepkuss
Copy link
Collaborator

Summary

The latest version of wasi_logging plugin provides support for "dumping" log data to stdout and stderr. There is also a solid requirement for saving log data to a log file.

Details

It would be great if the following requirements can be satisfied:

  1. Dump log data to a file with the extension .log.
  2. It would be better to allow user to specify the filename.
  3. Use an environment variable, for example WASM_LOG, to specify the log level.

Appendix

No response

@apepkuss apepkuss added the enhancement New feature or request label May 13, 2024
@q82419 q82419 self-assigned this May 15, 2024
@q82419
Copy link
Collaborator

q82419 commented May 15, 2024

@apepkuss ,

  1. Where's the example (rust) using this plugin?
  2. I think the context ("stderr" or "stdout") will be the filename or console to logging.
  3. It's not necessary. The logging level is in the function parameter already.

@hydai
Copy link
Member

hydai commented May 15, 2024

@apepkuss
Copy link
Collaborator Author

@q82419 For some scenarios, it's required to log the running data to a file instead of stderr and stdout. For example, dump the log info to common.log file so that another app or program analyzes the log info further.

@q82419
Copy link
Collaborator

q82419 commented May 15, 2024

@q82419 For some scenarios, it's required to log the running data to a file instead of stderr and stdout. For example, dump the log info to common.log file so that another app or program analyzes the log info further.

Of course but I didn't challenge about that.

@q82419
Copy link
Collaborator

q82419 commented May 22, 2024

Implemented in #3416

@q82419 q82419 closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants