Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small model needed for integration tests #8

Open
kylase opened this issue Sep 16, 2018 · 3 comments
Open

Small model needed for integration tests #8

kylase opened this issue Sep 16, 2018 · 3 comments

Comments

@kylase
Copy link

kylase commented Sep 16, 2018

Currently most of the integration tests such as APIs are disabled during CI because the model takes more than 4 GB to run and Travis is unable to fulfill the memory requirements.

Hence, when the PyTorch model is implemented, a small reference model needs to be prepared for integration tests.

@knmnyn
Copy link
Member

knmnyn commented Sep 16, 2018

Agree with your assessment that a small reference model is needed with unit / integration tests. That will be helpful for others to assess whether to adopt it or not.

@knmnyn knmnyn closed this as completed Sep 16, 2018
@knmnyn knmnyn reopened this Sep 16, 2018
@kylase kylase added this to the PyTorch Implementation milestone Sep 16, 2018
@animeshprasad
Copy link

@kylase Maybe ability to load a model without any embedding layer altogether. This way all the code flow can be checked however it might require a lot of effort to make all functionality to work without one hot to embedding conversion operation including train and test input. The other way is to check with a dummy model with Vocab = 10 and rest all assigned as one . The latter should be easier to do.

@kylase
Copy link
Author

kylase commented Nov 14, 2018

Based on my preliminary experience with PyTorch, it seems like the memory usage will not be as much as the current Theano's model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PyTorch Port
  
Awaiting triage
Development

No branches or pull requests

3 participants