extension Unload event should be sent to extension when user disabled them

[friday]

Environment

Any

Bug description

The extension Unload event is sent to extensions when Ulauncher is closed, but not when you manually close them.

It is located in Client.py which is called when the socket closes. It should be triggered in the stop method instead.

Ulauncher/ulauncher/api/client/Client.py

Line 61 in a41e515

self.extension.trigger_event({"type": "event:unload"})

Ulauncher/ulauncher/modes/extensions/ExtensionRuntime.py

Lines 58 to 70 in a41e515

	async def stop(self) -> None:
	"""
	Terminates extension
	"""
	logger.info('Terminating extension "%s"', self.ext_id)
	self.subprocess.send_signal(signal.SIGTERM)
	await asyncio.sleep(0.5)
	if self.subprocess.get_identifier():
	logger.info("Extension %s still running, sending SIGKILL", self.ext_id)
	# It is possible that the process exited between the check above and this signal,
	# luckily the subprocess library handles the signal delivery in race-free way, so this
	# is safe to do.
	self.subprocess.send_signal(signal.SIGKILL)

Log output

No response

Communication guidelines

• I have read and agree with Ulauncher's communication guidelines and checked the troubleshooting page for self-help.
• I have tried to understand the error message and help myself, before reporting it.
• My issue description has clear steps for how to reproduce the issue.
• This issue applies to the whole Ulauncher application, not for a specific extension.

Ulauncher v6

• I have made sure the bug isn't already fixed in v6.