Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fiber reconciler add support for application lifecycle events #547

Open
shial4 opened this issue Aug 26, 2023 · 0 comments
Open

fiber reconciler add support for application lifecycle events #547

shial4 opened this issue Aug 26, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@shial4
Copy link

shial4 commented Aug 26, 2023

Describe the bug

Missing triggers for below app lifecycle calls, breaks many modifier or views which depends on this functionality, internally inside TokamakCore as externally inside TokamakDOM and so on.

To Reproduce

Use fiber

static let _configuration: _AppConfiguration = .init(
    reconciler: .fiber(useDynamicLayout: true)
  )

Observe, a lot of functionality isn't working due to missing calls for

._onMount {
    print("🟡 _onMount")
}
._onUpdate {
    print("🟡 _onUpdate")
}
.onAppear {
    print("🟡 onAppear")
}
.onDisappear {
    print("🟡 onDisappear")
}

Expected behaviour

Calls work as expected.

@shial4 shial4 added the bug Something isn't working label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants