@marklonquist Thanks Mark! Good job!
I guess overriding global settings by Route local ones are covered by current unit tests, scenarios, right?

Additionally I've added commits to make code quality better.
And finally, Approved it!

Thanks for the PR! Can you update the docs so people know how to use it?

@TomPallister Yes, we can!
Thank you for your advice!

@marklonquist Hey Mark!
The feature branch has been rebased onto ThreeMammals:develop successfully!
Welcome to code review!

@marklonquist

@TomPallister commented on Jun 4

According to the Tom's request we have to add documentation for this feature.
Do you have time to contribute?

very busy with work and familiy-life. I don't know exactly when I can have time to make docs for this.

@marklonquist commented on Oct 13

🆗 No worries! Take care about your family, and work & life balance!
Our team will return to this PR back after merging of 30+ open PRs with lower numbers... Or, I'll find a mentor...

fixed

I would appreciate it, if someone else can take over. I simply do not have the time to do any more work on this.

@marklonquist
Don't worry! We will complete this feature and deliver it.
I guess the readiness is ~80-90%. I need update the docs and perform final code review.
I hope the PR will be merged in 1 or 2 months. But I'm not sure on release date.

I'm just curious:
Do you use Ocelot currently in any Production environment?

@raman-m yes! We use it on multiple BIG ecom sites, one of which is https://www.jackjones.com

I actually just finished setting up kubernetes service discovery, but it doesn't work out of the box. Had to change the IKubeApiClient to be a singleton, because it doesn't work correctly when it is scoped it seems.

Error Code: UnableToFindLoadBalancerError Message: unabe to find load balancer for /api/order/{everything}|Get,Put,Post,Delete,Head,Options| exception is System.InvalidOperationException: Cannot resolve scoped service 'KubeClient.IKubeApiClient' from root provider.

@marklonquist

I actually just finished setting up kubernetes service discovery, but it doesn't work out of the box. Had to change the IKubeApiClient to be a singleton, because it doesn't work correctly when it is scoped it seems.

Error Code: UnableToFindLoadBalancerError Message: unabe to find load balancer for /api/order/{everything}|Get,Put,Post,Delete,Head,Options| exception is System.InvalidOperationException: Cannot resolve scoped service 'KubeClient.IKubeApiClient' from root provider.

I believe it should be injected as singleton.
The design of K8s feature contains caching load balancing keys in memory.
With injected singleton K8s should work.

As you may have noticed, most of Ocelot features are singleton services, historically by Tom's design.

Please, keep us updated about your K8s environment with Ocelot behavior, how it is stable etc.

I will provide you more detailed feedback on design of the interface on Monday...

@marklonquist

I actually just finished setting up kubernetes service discovery, but it doesn't work out of the box. Had to change the IKubeApiClient to be a singleton, because it doesn't work correctly when it is scoped it seems.

Error Code: UnableToFindLoadBalancerError Message: unabe to find load balancer for /api/order/{everything}|Get,Put,Post,Delete,Head,Options| exception is System.InvalidOperationException: Cannot resolve scoped service 'KubeClient.IKubeApiClient' from root provider.

I believe it should be injected as singleton. The design of K8s feature contains caching load balancing keys in memory. With injected singleton K8s should work.

As you may have noticed, most of Ocelot features are singleton services, historically by Tom's design.

Please, keep us updated about your K8s environment with Ocelot behavior, how it is stable etc.

the kuberetes package adds it with AddKubeClient which adds it as scoped by default 😄

ServiceCollectionServiceExtensions.AddScoped<KubeApiClient>(services, new Func<IServiceProvider, KubeApiClient>(ResolveWithPodServiceAccount));
ServiceCollectionServiceExtensions.AddScoped<IKubeApiClient>(services, new Func<IServiceProvider, IKubeApiClient>(ResolveWithPodServiceAccount));

anyway this is outside if this PRs scope.

The feature branch has been rebased onto release/24.0 with top commit 59b63ea !

@marklonquist Mark,
Could you review and fix failed tests please❓

TODOs

• Clean up the feature branch from redundant commits related to QoS feature (aka Polly related ones)