Routing question: placeholders vs slash #658

skyflyer · 2018-10-11T13:31:41Z

Expected Behavior

Request to /api/ would go to / downstream
Request to /api/test would go to /test downstream

Actual Behavior / Motivation for New Feature

Reqeust to /api/ is not resolved (see error below)
Request to /api/test goes to downstream `/test

Steps to Reproduce the Problem

Have something listening on localhost:8000
Configure ocelot to listen on localhost:5000
Use config below

Config:

{
    "ReRoutes": [
        {
            "DownstreamPathTemplate": "/{everything}",
            "DownstreamScheme": "http",
            "DownstreamHostAndPorts": [
                {
                    "Host": "localhost",
                    "Port": 8000
                }
            ],
            "UpstreamPathTemplate": "/api/{everything}",
            "UpstreamHttpMethod": [
                "GET",
                "POST"
            ]
        }
    ],
    "GlobalConfiguration": {
        "BaseUrl": "http://localhost:5000"
    }
}

Specifications

Version: 12.0.1
Platform: mac
Subsystem: ?

Comments

It is interesting to note, that if I configure ReRoute as /{everything} -> /{everything}, then it works, so it seems to me that {everything} wildcard match is not consistent in theese two cases.

The text was updated successfully, but these errors were encountered:

TomPallister · 2018-10-13T10:52:07Z

@skyflyer

Request to /api/ would go to / downstream

This doesn't work because /{everything} expects something after the slash, you need a reroute that is just /

Request to /api/test goes to downstream `/test

Not sure if this is a typo? I assume it's working?

skyflyer · 2018-10-13T18:29:56Z

So here is what is puzzling me (it is unexpected).

Scenario 1

Config 1

{
    "ReRoutes": [
        {
            "DownstreamPathTemplate": "/{everything}",
            "DownstreamScheme": "http",
            "DownstreamHostAndPorts": [
                {
                    "Host": "localhost",
                    "Port": 8000
                }
            ],
            "UpstreamPathTemplate": "/{everything}",
            "UpstreamHttpMethod": [
                "GET",
                "POST"
            ],
            "RateLimitOptions": {
                "EnableRateLimiting": true,
                "ClientWhiteList": [],
                "Period": "1s",
                "Limit": 1,
                "PeriodTimespan": 5
            }
        }
    ],
    "GlobalConfiguration": {
        "BaseUrl": "http://localhost:5000",
        "RateLimitOptions": {
            "DisableRateLimitHeaders": false,
            "QuotaExceededMessage": "Over limit",
            "HttpStatusCode": 429
          }
    }
}

Config1, where I configure that everything coming to ocelot, goes to localhost:8000 works. So here, the pattern is /{everything} and it matches even / and also /ocelot.json and all works as one would expect.

request to http://localhost:5000/ returns content from http://localhost:8000/
request to http://localhost:5000/ocelot.json returns content from http://localhost:8000/ocelot.json

Scenario 2

Config2

{
    "ReRoutes": [
        {
            "DownstreamPathTemplate": "/{everything}",
            "DownstreamScheme": "http",
            "DownstreamHostAndPorts": [
                {
                    "Host": "localhost",
                    "Port": 8000
                }
            ],
            "UpstreamPathTemplate": "/api/{everything}",
            "UpstreamHttpMethod": [
                "GET",
                "POST"
            ],
            "RateLimitOptions": {
                "EnableRateLimiting": true,
                "ClientWhiteList": [],
                "Period": "1s",
                "Limit": 1,
                "PeriodTimespan": 5
            }
        }
    ],
    "GlobalConfiguration": {
        "BaseUrl": "http://localhost:5000",
        "RateLimitOptions": {
            "DisableRateLimitHeaders": false,
            "QuotaExceededMessage": "Over limit",
            "HttpStatusCode": 429
          }
    }
}

Based on the Config1, I would expect similar behaviour, only it is not, and I believe it should be (at least based on my experience with Apache and Nginx proxy setttings.

request to http://localhost:5000/api return 404 (?)
request to http://localhost:5000/api/ returns 404 (?)
request to http://localhost:5000/api/ocelot.json returns content from http://localhost:8000/ocelot.json (expected)

Are you saying that if I want to achieve that, I would need to configure two ReRoutes? One for /api/ and one for /api/{everything}?

TomPallister · 2018-10-21T16:45:45Z

@skyflyer yeh i think I might be wrong. This probably should work the way you expect but I don't know why it doesnt :/ I will mark this as a bug and see if we can get a fix!

raman-m · 2023-08-05T15:27:57Z

The issue has been accepted due to open PR #1333 by @AndyConlisk :

#658 Change upstream Regex to account for blank placeholders #1333

raman-m · 2023-08-14T15:56:26Z

Related to

TomPallister added the question Initially seen a question could become a new feature or bug or closed ;) label Oct 13, 2018

TomPallister added bug Identified as a potential bug and removed question Initially seen a question could become a new feature or bug or closed ;) labels Oct 21, 2018

philproctor added the help wanted Not actively being worked on. If you plan to contribute, please drop a note. label Jan 9, 2019

AndyConlisk linked a pull request Sep 4, 2020 that will close this issue

#658 Change upstream Regex to account for blank placeholders #1333

Open

raman-m added accepted Bug or feature would be accepted as a PR or is being worked on and removed help wanted Not actively being worked on. If you plan to contribute, please drop a note. labels Aug 5, 2023

raman-m changed the title ~~ReRouting question~~ Routing question: placeholders vs slash Aug 5, 2023

raman-m assigned skyflyer Aug 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Routing question: placeholders vs slash #658

Routing question: placeholders vs slash #658

skyflyer commented Oct 11, 2018

TomPallister commented Oct 13, 2018

skyflyer commented Oct 13, 2018

TomPallister commented Oct 21, 2018

raman-m commented Aug 5, 2023

raman-m commented Aug 14, 2023