Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous Code: Incorrect assignment message in lesson description in scrimba video lesson #27852

Open
2 of 3 tasks
Arthwr opened this issue Apr 24, 2024 · 3 comments
Open
2 of 3 tasks
Labels
Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues

Comments

@Arthwr
Copy link

Arthwr commented Apr 24, 2024

Checks

Describe your suggestion

In a Scrimba video lesson (this part), there's an assignment to fetch cat data using the Fetch API, with the instruction to "Make sure to convert that data to JSON data" and "Build a callback function to accept the JSON data". However, this wording is misleading, as the .json() method actually parses JSON data into a JavaScript object, rather than converting it into JSON format. We can also see that file source that needs to be fetched for the assignment has .json format.

According to the MDN documentation: "Note that despite the method being named json(), the result is not JSON but is instead the result of taking JSON as input and parsing it to produce a JavaScript object."

Screenshot_20240424_214006

Sidenote: not really sure how hard it is to modify scrimba video comments on that video, but wanted to point out the inconsistency just in case.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-javascript-asynchronous-code

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

@wise-king-sullyman
Copy link
Member

This does seem like it could be a bit more explicitly clear, but I don't think the scrims are something we're able to edit.

@michaella23 it looks like you added this scrim, what would the process to make this edit be?

@michaella23
Copy link
Contributor

@michaella23 it looks like you added this scrim, what would the process to make this edit be?

Hello! I think that the scrim would have to be re-recorded. I can speak with the team if that is something that seems imperative. :)

Copy link

This issue is stale because it has had no activity for the last 30 days.

@github-actions github-actions bot added the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues
Projects
None yet
Development

No branches or pull requests

3 participants