Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmark Crashed Issue Fixed #4154

Open
wants to merge 2 commits into
base: release/4.0
Choose a base branch
from
Open

Bookmark Crashed Issue Fixed #4154

wants to merge 2 commits into from

Conversation

msaqeeb72
Copy link
Contributor

@msaqeeb72 msaqeeb72 commented Apr 17, 2024 •
edited

Bookmark Crashed Issue Fixed, added check for empty name and valid path before adding bookmark.

fixes #4143

Description

Issue tracker

Automatic tests

  • Added test cases

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

VishnuSanal
VishnuSanal approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@VishnuSanal VishnuSanal left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected in testing, looks good to me, good to go! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VishnuSanal VishnuSanal VishnuSanal approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Creating a bookmark with empty directory causes error when attempting to open the bookmark
2 participants
@msaqeeb72 @VishnuSanal