Incorrect Copy Loop Detection Due to String#contains
Logic
#4131
Labels
Area-FileOperations
Related to file operations (e.g. moving, copying, renaming).
Issue-Bug
Related unexpected behavior or something worth investigating.
Summary:
The
isCopyLoopPossible
method incorrectly identifies a copy loop for similar but non-overlapping directory paths due to reliance on stringcontains
logic. Located at app/src/test/java/com/amaze/filemanager/filesystem/OperationsTest.javaTo Reproduce
Steps to reproduce the behavior:
isCopyLoopPossible
method programmatically within the app, passing a source file path and a target file path where the target path is similar but not actually a subdirectory of the source (e.g.,/documents/work
and/documents/workk
).Expected behavior
The method should return
false
, indicating no copy loop is possible because the target directory is not a subdirectory of the source directory.Actual Outcome
The method returns
true
, incorrectly suggesting a copy loop is possible due to the similarity of the paths.Screenshots
For this unit test:
Smartphone (please complete the following information):
N/A
Additional context
There was no GUI error. Tried reproducing error on small scale on GUI with android emulator and no issues. Although, when trying to copy parent directory into subdirectory of itself, it copied over just empty directory. Could cause problems on a larger scale.
The text was updated successfully, but these errors were encountered: