-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hex Editor Display issues on linux #3925
Comments
I have a local fix but I'm having issues with my SSH keys for this acc. Here's my diff. My only guess is this is some DPI/font issue. My thought is if this code is DPI dependent, then that could change the meaningful value of both the I also figure that changing the maximum width of the hex editor to be very large is pretty safe. And that the diff --git a/src/BizHawk.Client.EmuHawk/tools/HexEditor/HexEditor.Designer.cs b/src/BizHawk.Client.EmuHawk/tools/HexEditor/HexEditor.Designer.cs
index cad33f5aa..3ae7b8c1a 100644
--- a/src/BizHawk.Client.EmuHawk/tools/HexEditor/HexEditor.Designer.cs
+++ b/src/BizHawk.Client.EmuHawk/tools/HexEditor/HexEditor.Designer.cs
@@ -417,7 +417,7 @@ namespace BizHawk.Client.EmuHawk
this.MemoryViewerBox.Controls.Add(this.AddressesLabel);
this.MemoryViewerBox.Font = new System.Drawing.Font("Microsoft Sans Serif", 8.25F, System.Drawing.FontStyle.Underline, System.Drawing.GraphicsUnit.Point, ((byte)(0)));
this.MemoryViewerBox.Location = new System.Drawing.Point(12, 27);
- this.MemoryViewerBox.MaximumSize = new System.Drawing.Size(600, 1024);
+ this.MemoryViewerBox.MaximumSize = new System.Drawing.Size(1920, 1024);^M
this.MemoryViewerBox.MinimumSize = new System.Drawing.Size(260, 180);
this.MemoryViewerBox.Name = "MemoryViewerBox";
this.MemoryViewerBox.Size = new System.Drawing.Size(560, 262);
@@ -552,4 +552,4 @@ namespace BizHawk.Client.EmuHawk
private BizHawk.WinForms.Controls.ToolStripMenuItemEx ExportMenuItem;
private BizHawk.WinForms.Controls.ToolStripMenuItemEx importAsBinaryToolStripMenuItem;
}
-}
\ No newline at end of file
+}^M
diff --git a/src/BizHawk.Client.EmuHawk/tools/HexEditor/HexEditor.cs b/src/BizHawk.Client.EmuHawk/tools/HexEditor/HexEditor.cs
index df99162fc..f9a92a8a0 100644
--- a/src/BizHawk.Client.EmuHawk/tools/HexEditor/HexEditor.cs
+++ b/src/BizHawk.Client.EmuHawk/tools/HexEditor/HexEditor.cs
@@ -169,10 +169,9 @@ namespace BizHawk.Client.EmuHawk
// character so we'll see how much the width increases on the second character.
var fontSize1 = TextRenderer.MeasureText("0", font);
var fontSize2 = TextRenderer.MeasureText("00", font);
+ var fontSize3 = TextRenderer.MeasureText("0\n0", font);^M
_fontWidth = fontSize2.Width - fontSize1.Width;
- _fontHeight = fontSize1.Height;
- const int MAGIC_FIX_NUMBER_H = 4; // don't wanna know
- if (OSTailoredCode.IsUnixHost) _fontHeight -= MAGIC_FIX_NUMBER_H;
+ _fontHeight = fontSize3.Height - fontSize1.Height;^M
InitializeComponent();
Icon = ToolIcon; |
Summary
Issues:
Occurs on all cores I've tried, on stable and master
Repro
Host env.
The text was updated successfully, but these errors were encountered: