Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type hints in Stingray #544

Open
matteobachetti opened this issue Feb 19, 2021 · 3 comments
Open

Use type hints in Stingray #544

matteobachetti opened this issue Feb 19, 2021 · 3 comments
Labels
GSoC Great for students interested in GSoC to tackle. help wanted We need additional help with these issues!

Comments

@matteobachetti
Copy link
Member

matteobachetti commented Feb 19, 2021 •
edited

Using the syntax proposed in PEP 484, we should introduce type hints. It will make the library easier to debug and, maybe, to optimize using external libraries.
@matteobachetti matteobachetti added GSoC Great for students interested in GSoC to tackle. help wanted We need additional help with these issues! labels Feb 4, 2022
@matteobachetti matteobachetti mentioned this issue Feb 15, 2022
Merged
@parkma99
Copy link
Contributor

parkma99 commented Mar 8, 2022

Hello , I am a graduate student from NAOC. I would like to help to add type hints.
And I added type hints to base.py. PR: #649

matteobachetti added a commit that referenced this issue Mar 16, 2022
@matteobachetti
Merge pull request #649 from parkma99/main
a6dec24 
Add type hints to base.py #544
@mohamedmostafadawood
Copy link

#651
May you please review my pull request?

@pupperemeritus pupperemeritus mentioned this issue Mar 18, 2023
Closed
@pupperemeritus
Copy link
Contributor

pupperemeritus commented Mar 19, 2023 •
edited

I added type hints to bexvar.py #708 and crossspectrum.py #710. Will add typehints to powerspectrum.py as well soon in #710 itself.

@pupperemeritus pupperemeritus mentioned this issue Mar 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GSoC Great for students interested in GSoC to tackle. help wanted We need additional help with these issues!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matteobachetti @pupperemeritus @mohamedmostafadawood @parkma99