Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model bounds ignored #463

Open
matteolucchini1 opened this issue Apr 9, 2020 · 4 comments
Open

Model bounds ignored #463

matteolucchini1 opened this issue Apr 9, 2020 · 4 comments
Labels
bug It's a bug! Unexpected or unwanted behavior. GSoC Great for students interested in GSoC to tackle. high-priority High priority issues

Comments

@matteolucchini1
Copy link
Collaborator

Hi everyone,
I'm having an issue with the modelling interface. I'm modelling the PSD of an X-ray binary trying to identify and subtract the QPOs from the broadband noise, and the issue I'm having is that when fitting the PSD the modelling bounds I'm imposing are neglected by the fit. As a result I get unphysical results and/or poorly constrained parameters (such as negative normalisations of components that should be additive).
I have uploaded a tarball including one of the lightcurves I'm working on and a Jupyter notebook to replicate the issue here: https://drive.google.com/file/d/1k8D-4F4h0H98D5fIqYTxBvcEqSWbTkLi/view?usp=sharing

@matteolucchini1 matteolucchini1 changed the title Model bounds ignored by interface Model bounds ignored Apr 9, 2020
@matteobachetti matteobachetti added the high-priority High priority issues label Jan 18, 2021
@matteobachetti matteobachetti added bug It's a bug! Unexpected or unwanted behavior. GSoC Great for students interested in GSoC to tackle. labels Feb 4, 2022
@abigailStev abigailStev added this to the Version 1 code milestone Feb 8, 2022
@matteobachetti
Copy link
Member

@dhuppenkothen I think this goes with the planned re-write of the modeling interface. Probably too complicated to address before 1.0.0?
(Sorry for the extremely slow progress @matteolucchini1 , but this issue is produced by an evil mixture of Stingray's infrastructure and the somewhat inconsistent behavior of scipy's fitting interface)

@abigailStev
Copy link
Member

Just came here to comment on this as well. Is there a little patch we can include for v1.0, and properly overhaul it with the rest of modeling in the future?

@matteobachetti
Copy link
Member

I'm not confident that this will take a little patch 😅

@abigailStev
Copy link
Member

I'll put a warning in the release notes for v1.0

@abigailStev abigailStev removed this from the version 1.0.0 code milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug! Unexpected or unwanted behavior. GSoC Great for students interested in GSoC to tackle. high-priority High priority issues
Projects
None yet
Development

No branches or pull requests

3 participants