Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cross-correlation functionality to accept CrossSpectrum objects? #428

Open
davis191 opened this issue Aug 8, 2019 · 6 comments
Open
Assignees
Labels
feature Additional functionality. GSoC Great for students interested in GSoC to tackle.
Milestone

Comments

@davis191
Copy link
Contributor

davis191 commented Aug 8, 2019

Hi,

Currently, the cross-correlation function only accepts two lightcurve objects. It would help to have the option to have an Average/Crossspectrum object be a potential input as well.

pinging: @abigailStev @swapsha96

@swapsha96
Copy link
Contributor

Also pinging @dhuppenkothen @matteobachetti

@matteobachetti
Copy link
Member

Thanks @davis191, good suggestion. I don't personally know when I'll have the time to work on this, but if you and/or someone else come out with an implementation I can help adapting it to our code.

@swapsha96
Copy link
Contributor

Where does one begin to implement it? Any details?

@matteobachetti
Copy link
Member

Isn't the cross correlation just the inverse Fourier transform of the cross spectrum? If so, the implementation should be very straightforward. The relevant class is in stingray/crosscorrelation.py. We could modify the __init__ method to allow a cross spectrum object.

@davis191
Copy link
Contributor Author

Yeah! It should be fairly simple. I can give it a go this afternoon!

@matteobachetti matteobachetti added the low-priority Low-priority issues. label Jan 18, 2021
@abigailStev abigailStev self-assigned this Mar 29, 2022
@abigailStev abigailStev added the feature Additional functionality. label Mar 29, 2022
@abigailStev abigailStev added this to the version 1.1 milestone Mar 29, 2022
@abigailStev abigailStev added GSoC Great for students interested in GSoC to tackle. and removed low-priority Low-priority issues. labels Mar 29, 2022
@mohamedmostafadawood
Copy link

Hi , has this issue been solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Additional functionality. GSoC Great for students interested in GSoC to tackle.
Projects
None yet
Development

No branches or pull requests

5 participants