New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CancelCommand.Wrap does not propagate IsCancelled information #30

Open

bitbonk opened this issue Feb 14, 2020 · 0 comments · May be fixed by #31

Assignees

bitbonk commented Feb 14, 2020 •

edited

The current version CancelCommand.Wrap() does not propagate IsCancelled information to the Execution.IsCancelled of the parent AsyncCommand.

In the following code

public AsyncCommandsDemoViewModel(IDataClient dataClient)
{
    this.CancelGetData = new CancelCommand();
    this.GetData = new AsyncCommand(
        this.CancelGetData.Wrap(
            async cancellationToken =>
                this.Data = await dataClient.GetDataAsync(cancellationToken)));
}

if the CancelGetData command is executed, GetData.Execuction.IsCancelled never becomes true.

The text was updated successfully, but these errors were encountered:

bitbonk linked a pull request

that will close this issue

Remove useless catch block #31

Open

StephenCleary self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment