Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add ability to toggle the filter using a configurable global hotkey #3

Open
Saxtus opened this issue Mar 7, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Saxtus
Copy link

Saxtus commented Mar 7, 2022

Please add the ability to toggle the filter using a configurable hotkey or any other method that we can automate (like calling a command-line argument or using an API).
Also would be nice to have some feedback on the success of the toggle, like a sound, for example.

@Saxtus Saxtus added the enhancement New feature or request label Mar 7, 2022
@Speyedr
Copy link
Owner

Speyedr commented Mar 7, 2022

This sounds like a solid idea and I think this can be done, however, there are a couple things I'll need to consider:

  • What keybinds would be compatible while playing GTA Online? Should it be a single key press, or a SHIFT / CTRL combination?
    • Can keys be captured reliably while GTA is the active window / full screen?
  • The keybind feature should be disable-able so people who don't want it don't accidentally trigger it by accident and think the program is broken.
  • Encoding this keybind combination into settings.ini will be interesting but definitely possible.
  • Adding an additional key capture into wait_for_valid_key() will require a bit of thinking. Don't want to rework input detection.
  • For a bit of fun I might even write the notification sounds myself.
    • That being said, should they be actual sound files, or just windows notification sounds?
  • And, of course, the sounds should be disable-able because people might find them annoying.

I'll see if I can fit some time in this week to get it done.

@Speyedr Speyedr added the good first issue Good for newcomers label Mar 7, 2022
@Saxtus
Copy link
Author

Saxtus commented Mar 7, 2022

  • If possible, I will bind it to an invisible button, like F13 for example (would call it through my Steam Deck)
  • Sound should be optional. Letting users to define their own .wav file path for toggle on and another for toggle off, would be nice, defaulting to silence if no paths specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants