Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all taxon names are found using the search box. #193

Open
proceps opened this issue Nov 16, 2023 · 13 comments
Open

Not all taxon names are found using the search box. #193

proceps opened this issue Nov 16, 2023 · 13 comments
Labels
enhancement New feature or request

Comments

@proceps
Copy link

proceps commented Nov 16, 2023

Taxon names without OTU are not found on TaxonPages. I have most of the combinations without OTUs. When I search for a combination name, the system return no resuts. I got complains from users, that they cannon find taxa they are looking for. An example: 'Limotettix anthracinus'.

@proceps proceps added the bug Something isn't working label Nov 16, 2023
@mjy
Copy link
Member

mjy commented Nov 17, 2023

If you make an OTU for that taxon does it work?

@proceps
Copy link
Author

proceps commented Nov 17, 2023

I cannot make OTUs for all combination, this will significantly complicate the editing process.

@mjy
Copy link
Member

mjy commented Dec 6, 2023

Since there is no OTU with that combination name we can't show it in the list without a major refactor, and keeping priority (position in the list) across this is hard. I can tweak it to find the target protonym at least:

Screenshot 2023-12-06 at 3 31 05 PM

In addition, that string isn't in the system to start with, it's in a subgenus format, so even if we do tweak the user still won't see the exact string they looked for. So, this is tricky, and I'm not sure worth the refactor at this point? Exploring a little with anthracinus by itself will let you find it in the synonym list.

@proceps
Copy link
Author

proceps commented Dec 6, 2023

" Delphacodes hyas", "Empoasca vitis" - those are exact match for combination, and the system does not find them. Classification in some lineages change fast, and all user know is an older name.

@mjy
Copy link
Member

mjy commented Dec 6, 2023

Pedantically: 'Empoasca vitis" -> 'Empoasca vitium' (so not an exact match), and it took me 30 seconds to find "Delphacodes hyas" by dropping to search for "hyas". I do understand that we can do better.

@mjy mjy added enhancement New feature or request and removed bug Something isn't working labels Dec 6, 2023
@proceps
Copy link
Author

proceps commented Apr 18, 2024

This is getting critical, I getting more complains that the names are not found on the TaxonPages. Today I got a request for "Stirellus indrus" which is present in TW, but not found using TP interface.

@LocoDelAssembly
Copy link
Contributor

If this has to do with the having_taxon_name_only=true option (which means only OTUs with Otu.name=nil), please do not disable globally @jlpereira (at least not initially), do only for hoppers.

@mjy
Copy link
Member

mjy commented Apr 18, 2024

@proceps Please inspect the JSON and play with the parameters as @LocoDelAssembly notes, if you can find a parameterized solution we can adopt that, but see my commnet on OTUs being the problem above.

@proceps
Copy link
Author

proceps commented Apr 18, 2024

I have no OTUs on subsequent combination. This is intentional. Now I can search only by original combination and current combination.

@mjy
Copy link
Member

mjy commented Apr 18, 2024

@proceps find the underlying JSON query and play with the parameter having_taxon_name_only

@proceps
Copy link
Author

proceps commented Apr 18, 2024

having_taxon_name_only means that OTU exists, but the name field is blank

@mjy
Copy link
Member

mjy commented Apr 18, 2024

@proceps Please add a failing spec or two (change specify to xspecify after you get the spec in place and working) to spec/lib/queries/otu/autocomplete.rb, we're not going to make progress without that in place.

@proceps
Copy link
Author

proceps commented Apr 22, 2024

added a spec test

mjy added a commit to SpeciesFileGroup/taxonworks that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants