New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in sample code checking flags #66

Open

timglauertadder opened this issue Jan 9, 2024 · 0 comments

timglauertadder commented Jan 9, 2024

The sample code contains the follow tests:

.read((flags & O_RDONLY != 0) | (flags & O_RDWR != 0))
.write((flags & O_WRONLY != 0) | (flags & O_RDWR != 0))

However O_RDONLY is 0 so the test is bogus and gives a clippy warning.

The O_XXXXvalues are not bit masks but rather they are values for the two low order bits of the flags value. The tests should probably look somethign like this:

.read((flags & 3) == O_RDONLY || (flags & 3) == O_RDWR)
.write((flags & 3) == O_WRONLY || (flags & 3) == O_RDWR)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment