Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display warning when 3D image is saved as TIFF file #7588

Open
lassoan opened this issue Feb 14, 2024 · 2 comments
Open

Display warning when 3D image is saved as TIFF file #7588

lassoan opened this issue Feb 14, 2024 · 2 comments
Labels
good first issue
Milestone
Slicer 5.7

Comments

@lassoan
Copy link
Contributor

lassoan commented Feb 14, 2024

Summary

Users may not know that TIFF file cannot store image orientation and Z spacing and so they lose this information when saving the scene.

See for example this user error report: https://discourse.slicer.org/t/older-scenes-and-specimens-loading-incorrectly/34328

Steps to reproduce

  • Load MRHead example
  • Save as TIFF file => ERROR: no warning is displayed
  • Load the TIFF file => ERROR: the image is distorted

Environment

  • Slicer version: Slicer-5.6.1
  • Operating system: Windows11
@lassoan lassoan added this to the Slicer 5.7 milestone Feb 14, 2024
@lassoan
Copy link
Contributor Author

lassoan commented Feb 15, 2024

It would be better to change the default file format for 3D images loaded from TIFF to nrrd.

@pieper
Copy link
Member

pieper commented Feb 15, 2024

I believe in the past the mrml node's ijkToRAS was preserved when saving to formats like jpg or tiff (e.g. when the mrml file points to the original data), but avoiding any ambiguity in save/restore is the most important goal, so making nrrd be the default for new storage makes good sense.

aramSofthenge added a commit to Softhenge/Slicer that referenced this issue Mar 1, 2024
@aramSofthenge
ENH: Add TIFF format warning window
eae8337 
Adds warning for TIFF file format saving. Prevents potential data loss.

Issue Slicer#7588
aramSofthenge added a commit to Softhenge/Slicer that referenced this issue Mar 1, 2024
@aramSofthenge
ENH: Add TIFF format warning window
c4ffc32 
Adds warning for TIFF file format saving. Prevents potential data loss.

Issue Slicer#7588
@aramSofthenge aramSofthenge mentioned this issue Mar 1, 2024
Closed
aramSofthenge added a commit to Softhenge/Slicer that referenced this issue Mar 6, 2024
@aramSofthenge
ENH: Add TIFF format warning window
ee8b6f5 
Adds warning for TIFF file format saving. Prevents potential data loss.

Issue Slicer#7588
aramSofthenge added a commit to Softhenge/Slicer that referenced this issue Mar 7, 2024
@aramSofthenge
ENH: Add TIFF format warning window
d4280c9 
Adds warning for TIFF file format saving. Prevents potential data loss.

Issue Slicer#7588
lassoan added a commit to lassoan/Slicer that referenced this issue Mar 22, 2024
@aramSofthenge @lassoan
ENH: Display warning when saving into TIFF format
1f85b13 
Adds warning for TIFF file format saving. Prevents potential data loss.
Made translatable all messages that may be relevant to users.

see Slicer#7588

Co-authored-by: Andras Lasso <lasso@queensu.ca>
lassoan added a commit to lassoan/Slicer that referenced this issue Mar 22, 2024
@aramSofthenge @lassoan
ENH: Display warning when saving into TIFF format
450a933 
Adds warning for TIFF file format saving. Prevents potential data loss.
Made translatable all messages that may be relevant to users.

see Slicer#7588

Co-authored-by: Andras Lasso <lasso@queensu.ca>
lassoan added a commit to lassoan/Slicer that referenced this issue Mar 22, 2024
@aramSofthenge @lassoan
ENH: Display warning when saving into TIFF format
534883a 
Adds warning for TIFF file format saving. Prevents potential data loss.
Made translatable all messages that may be relevant to users.

see Slicer#7588

Co-authored-by: Andras Lasso <lasso@queensu.ca>
lassoan added a commit to lassoan/Slicer that referenced this issue Mar 22, 2024
@aramSofthenge @lassoan
ENH: Display warning when saving into TIFF format
c33335c 
Adds warning for TIFF file format saving. Prevents potential data loss.
Made translatable all messages that may be relevant to users.

see Slicer#7588

Co-authored-by: Andras Lasso <lasso@queensu.ca>
pieper pushed a commit that referenced this issue Mar 25, 2024
@lassoan @aramSofthenge
Show warning window if data loss occurs when saving to tiff (#7655)
64ab65b 
* BUG: Fix creation of translation template file for single language

When a language was specified for updating translations and no translation file was found for that language
then a new translation file was generated for en-US language. This commit changes this to generate translation file
for the specified language.

* ENH: Add helper function for MRML translation with placeholders

* ENH: Display warning when saving into TIFF format

Adds warning for TIFF file format saving. Prevents potential data loss.
Made translatable all messages that may be relevant to users.

see #7588

Co-authored-by: Andras Lasso <lasso@queensu.ca>

---------

Co-authored-by: Aram Harutyunyan <aram.harutyunyan@softhenge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Milestone
Slicer 5.7
Development

No branches or pull requests
2 participants
@pieper @lassoan