Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIP volume rendering MIP does not appear if shadows visibility is enabled #7560

Open
lassoan opened this issue Jan 25, 2024 · 3 comments
Open

MIP volume rendering MIP does not appear if shadows visibility is enabled #7560

lassoan opened this issue Jan 25, 2024 · 3 comments
Assignees
@lassoan
Milestone
Slicer 5.7

Comments

@lassoan
Copy link
Contributor

lassoan commented Jan 25, 2024

Summary

Volume rendering MIP (minimum/maximum intensity projection) is incompatible with shadows option. The volume does not appear if "Shadows visibility" option is enabled in the 3D view.

Environment

  • Slicer version: Slicer-5.7.0 2024-01-25
  • Operating system: all
@lassoan lassoan added this to the Slicer 5.7 milestone Jan 25, 2024
@lassoan lassoan self-assigned this Jan 25, 2024
@lassoan
Copy link
Contributor Author

lassoan commented Jan 25, 2024

We should document this and probably disable shadows by default and turn off shadows visibility if MIP is enabled (or display a warning message).

@lassoan
Copy link
Contributor Author

lassoan commented Jan 25, 2024

It seems that the volume does not appear due to shader compilation problem:

error C1503: undefined variable "shading_gradient"

Probably the best would be to fix this issue in VTK (e.g., do not try to compute shadows in MIP rendering).

lassoan added a commit to lassoan/Slicer that referenced this issue Feb 12, 2024
@lassoan
ENH: Disable shadows in 3D views by default
446e48e 
Shadows feature is not yet mature enough to be enabled by default. It may make rendering darker, not compatible with MIP, and the shader fails to compile if shading (normal computation) is disabled.

See Slicer#7560 for MIP incompatibility
See discussion about darkened look at https://discourse.slicer.org/t/are-shadows-enabled-by-default-for-volume-rendering-in-new-previews/34219
@lassoan lassoan mentioned this issue Feb 12, 2024
Merged
@jcfr
Copy link
Member

jcfr commented Feb 12, 2024

cc: @LucasGandel

lassoan added a commit that referenced this issue Feb 12, 2024
@lassoan
ENH: Disable shadows in 3D views by default
c1abfbf 
Shadows feature is not yet mature enough to be enabled by default. It may make rendering darker, not compatible with MIP, and the shader fails to compile if shading (normal computation) is disabled.

See #7560 for MIP incompatibility
See discussion about darkened look at https://discourse.slicer.org/t/are-shadows-enabled-by-default-for-volume-rendering-in-new-previews/34219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lassoan lassoan

Labels
None yet
Milestone
Slicer 5.7
Development

No branches or pull requests
2 participants
@jcfr @lassoan