Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on theme check #738

Open
ivandurst opened this issue Jul 25, 2023 · 2 comments
Open

Fail on theme check #738

ivandurst opened this issue Jul 25, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@ivandurst
Copy link

Stack trace

Theme check failed with error:
┃ /Users/ivandurst/Library/Caches/shopify-gems-nodejs/ruby/3.2.0/gems/theme-check-1.15.0/lib/theme_check/bug.rb:20:in `bug': Can't find a parseable tag of name img inside the parseable HTML. (ThemeCheck::ThemeCheckError)
┃ 
┃ Tag name:
┃   "img"
┃ 
┃ File:
┃   snippets/template-banner.liquid
┃ 
┃ Line number:
┃   10
┃ 
┃ Excerpt:
┃   ```
┃   image: <image object>
┃ mobile_image: <image object>
┃ mobile_crop: <string>
┃ banner_pretext: <string>
┃ banner_text: <string>
┃ banner_subheading: <string>
┃ 
┃   ```
┃ 
┃ Parseable Excerpt:
┃   ```
┃   image: <image object>
┃ mobile_image: <image object>
┃ mobile_crop: <string>
┃ banner_pretext: <string>
┃ banner_text: <string>
┃ banner_subheading: <string>
┃ 
┃   ```
┃ Theme Check Version: 1.15.0
┃ Ruby Version: 3.2.2
┃ Platform: x86_64-darwin21
┃ Muffin mode: activated

Debugging information

  • Mac Monterey
  • Version 1.15.0
@ivandurst ivandurst added the bug Something isn't working label Jul 25, 2023
@jocelyn-plentiful-commerce

+1 for me. I ran 'shopify theme check'.
But I'm on Mac Sonoma 14.0 and version 3

@chufucious
Copy link

Possibly related? #711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants