Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA-1 and SHA-256 x86 #23949

Open
MarekKnapek opened this issue Apr 13, 2024 · 2 comments
Open

SHA-1 and SHA-256 x86 #23949

MarekKnapek opened this issue Apr 13, 2024 · 2 comments

Comments

@MarekKnapek
Copy link

Hi, my name is Marek and I'm new here. I'm C++ and C developer. I have been watching Serenity development for a while. And today I decided to join. I have already developed x86 specific acceleration for various cryptographic functions such as SHA-1, SHA-256, SHA-512 and AES for my own project. I would like to add it to Serenity. First question: Would you like it? Second question: If yes, how should I do it? I need to add two tests: One is compile-time test for supported architecture (i386 and amd64) and for supported compilers (GCC >= 11.1 only so far). The second is run-time test for detecting presence of sha/aes instructions on processor and register saving by the OS on context switch. So... is there already some kind of infrastructure / best practices around cpuid?

My code is available at: https://github.com/MarekKnapek/serenity/commits/SHA1x86/

@MarekKnapek MarekKnapek changed the title SHA-1 x86 SHA-1 and SHA-256 x86 Apr 14, 2024
@MarekKnapek
Copy link
Author

Added SHA-256 on different branch: https://github.com/MarekKnapek/serenity/commits/SHAx86/

@MarekKnapek
Copy link
Author

Created pull request: #23958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant