Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Notice: Caller from Title::newFromIDs ignored #5539

Open
krabina opened this issue Oct 7, 2023 · 2 comments
Open

Deprecation Notice: Caller from Title::newFromIDs ignored #5539

krabina opened this issue Oct 7, 2023 · 2 comments
Labels
bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error mediawiki

Comments

@krabina
Copy link
Contributor

krabina commented Oct 7, 2023

Setup

  • SMW version: 4.1.2
  • MW version: 1.39
  • PHP version: 7.4
  • DB system (MySQL, Blazegraph, etc.) and version: MySQL

Issue

Running rebuldData.php sometimes show the notice below. Script continues with --ignore-exceptions

PHP Deprecated:  Caller from Title::newFromIDs ignored an error originally raised from SMW\SQLStore\PropertyTableUpdater::insert-smw_fpt_7t89r6bmadv0: [1054] Unknown column 'o_blob' in 'field list' in includes/debug/MWDebug.php on line 381
PHP Stack trace:
PHP   1. {main}() extensions/SemanticMediaWiki/maintenance/rebuildData.php:0
PHP   2. require_once() extensions/SemanticMediaWiki/maintenance/rebuildData.php:294
PHP   3. MediaWiki\Maintenance\MaintenanceRunner->run() maintenance/doMaintenance.php:85
PHP   4. SMW\Maintenance\rebuildData->execute() maintenance/includes/MaintenanceRunner.php:309
PHP   5. SMW\Maintenance\DataRebuilder->rebuild() extensions/SemanticMediaWiki/maintenance/rebuildData.php:198
PHP   6. SMW\Maintenance\DataRebuilder->rebuildAll() extensions/SemanticMediaWiki/src/Maintenance/DataRebuilder.php:224
PHP   7. SMW\Maintenance\DataRebuilder->doUpdateById() extensions/SemanticMediaWiki/src/Maintenance/DataRebuilder.php:385
PHP   8. SMW\SQLStore\Rebuilder\Rebuilder->rebuild() extensions/SemanticMediaWiki/src/Maintenance/DataRebuilder.php:472
PHP   9. SMW\SQLStore\Rebuilder\Rebuilder->matchAsTitle() extensions/SemanticMediaWiki/src/SQLStore/Rebuilder/Rebuilder.php:230
PHP  10. SMW\MediaWiki\TitleFactory->newFromIDs() extensions/SemanticMediaWiki/src/SQLStore/Rebuilder/Rebuilder.php:267
PHP  11. Title::newFromIDs() extensions/SemanticMediaWiki/src/MediaWiki/TitleFactory.php:53
PHP  12. Wikimedia\Rdbms\DBConnRef->select() includes/Title.php:557
PHP  13. Wikimedia\Rdbms\DBConnRef->__call() includes/libs/rdbms/database/DBConnRef.php:326
PHP  14. Wikimedia\Rdbms\DatabaseMysqli->select() includes/libs/rdbms/database/DBConnRef.php:103
PHP  15. Wikimedia\Rdbms\DatabaseMysqli->query() includes/libs/rdbms/database/Database.php:1711
PHP  16. Wikimedia\Rdbms\DatabaseMysqli->assertQueryIsCurrentlyAllowed() includes/libs/rdbms/database/Database.php:936
PHP  17. Wikimedia\Rdbms\TransactionManager->assertTransactionStatus() includes/libs/rdbms/database/Database.php:1391
PHP  18. call_user_func:{includes/libs/rdbms/database/TransactionManager.php:213}() includes/libs/rdbms/database/TransactionManager.php:213
PHP  19. MWLBFactory::logDeprecation() includes/libs/rdbms/database/TransactionManager.php:213
PHP  20. MWDebug::sendRawDeprecated() includes/db/MWLBFactory.php:491
PHP  21. trigger_error() includes/debug/MWDebug.php:381

Steps to reproduce the observation (recommendation is to use the sandbox):

@krabina krabina added the bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error label Oct 7, 2023
@krabina
Copy link
Contributor Author

krabina commented Oct 16, 2023

I noticed another one.

PHP Deprecated:  Use of Title::getSelectFields was deprecated in MediaWiki 1.36. [Called from Title::newFromIDs in includes/Title.php at line 555] in includes/debug/MWDebug.php on line 381
PHP Stack trace:
PHP   1. {main}() extensions/SemanticMediaWiki/maintenance/rebuildData.php:0
PHP   2. require_once() extensions/SemanticMediaWiki/maintenance/rebuildData.php:294
PHP   3. MediaWiki\Maintenance\MaintenanceRunner->run() maintenance/doMaintenance.php:85
PHP   4. SMW\Maintenance\rebuildData->execute() maintenance/includes/MaintenanceRunner.php:309
PHP   5. SMW\Maintenance\DataRebuilder->rebuild() extensions/SemanticMediaWiki/maintenance/rebuildData.php:198
PHP   6. SMW\Maintenance\DataRebuilder->rebuildAll() extensions/SemanticMediaWiki/src/Maintenance/DataRebuilder.php:224
PHP   7. SMW\Maintenance\DataRebuilder->doUpdateById() extensions/SemanticMediaWiki/src/Maintenance/DataRebuilder.php:385
PHP   8. SMW\SQLStore\Rebuilder\Rebuilder->rebuild() extensions/SemanticMediaWiki/src/Maintenance/DataRebuilder.php:468
PHP   9. SMW\SQLStore\Rebuilder\Rebuilder->matchAsTitle() extensions/SemanticMediaWiki/src/SQLStore/Rebuilder/Rebuilder.php:230
PHP  10. SMW\MediaWiki\TitleFactory->newFromIDs() extensions/SemanticMediaWiki/src/SQLStore/Rebuilder/Rebuilder.php:267
PHP  11. Title::newFromIDs() extensions/SemanticMediaWiki/src/MediaWiki/TitleFactory.php:53
PHP  12. Title::getSelectFields() includes/Title.php:555
PHP  13. wfDeprecated() includes/Title.php:507
PHP  14. MWDebug::deprecated() includes/GlobalFunctions.php:765
PHP  15. MWDebug::deprecatedMsg() includes/debug/MWDebug.php:233
PHP  16. MWDebug::sendRawDeprecated() includes/debug/MWDebug.php:352
PHP  17. trigger_error() includes/debug/MWDebug.php:381

@krabina
Copy link
Contributor Author

krabina commented Nov 20, 2023

See also #5017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error mediawiki
Projects
None yet
Development

No branches or pull requests

3 participants
@JeroenDeDauw @krabina and others