Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies. #199

Closed
HolonProduction opened this issue Feb 8, 2023 · 2 comments
Closed

Update dependencies. #199

HolonProduction opened this issue Feb 8, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@HolonProduction
Copy link
Contributor

When installing gdtoolkit one gets prompted with a warning about deprecated installation methods. Starting from pip 23.1 (we are currently at 23.0) a special flag will be needed to install the package. The warning is caused by two packages in the dependencies.

  • future which is in fact a dependency of radon. The future package is a python 2 polyfill and was already removed from the radon project. The change was not yet released but hopefully New release to drop future package rubik/radon#238 will get a response soon. So no action is needed for the moment.
  • The second warning comes from the docopt package. It has seen its last release on PiPy in 2014. The package is basically unmaintained and will see no further releases. According Is python-docopt still under maintenance? docopt/docopt#494 docopt-ng is the new maintained version of the package. It already uses the new setup process and can be used to as a drop-in replacement.

Also I don't see a reason for keeping lark at a fixed version. Is there any?

@Scony Scony added the enhancement New feature or request label Feb 8, 2023
@Scony
Copy link
Owner

Scony commented Feb 8, 2023

Sounds good, I'll take a look into it.

Regarding lark dependency, in the past, they've introduced major breaking changes between releases that broke gdtoolkit so I don't trust them anymore and therefore I prefer to update lark dependency manually.

@HolonProduction
Copy link
Contributor Author

Regarding lark dependency, in the past, they've introduced major breaking changes between releases that broke gdtoolkit so I don't trust them anymore and therefore I prefer to update lark dependency manually.

Seems fair. Having a look at their release history I would suspect that breaking changes were only introduced with the 1.0 update. After that they list no compat changes (there may be some smaller stuff). I guess I will give the upgrade a try when I find some time.

@Scony Scony added this to the 4.0 milestone Feb 8, 2023
@Scony Scony closed this as completed in 59a8977 Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants