Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PolyOpt only accept functions without any extra inputs #728

Open
prbzrg opened this issue Mar 28, 2024 · 1 comment
Open

PolyOpt only accept functions without any extra inputs #728

prbzrg opened this issue Mar 28, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@prbzrg
Copy link
Member

prbzrg commented Mar 28, 2024

As docs suggest for mini-batch, the loss function can be (u, p, xs_) -> vl and it works with OptimizationOptimisers but this line in OptimizationPolyalgorithms creates errors. Does using PolyOpt have an intended restriction on the loss function?

Optimization.jl/lib/OptimizationPolyalgorithms/src/OptimizationPolyalgorithms.jl

Line 14 in 8310517

loss, θ = x -> prob.f(x, prob.p), prob.u0

@ChrisRackauckas
Copy link
Member

Oh that just needs to splat the args

@ChrisRackauckas ChrisRackauckas added the good first issue Good for newcomers label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisRackauckas @prbzrg