WIP: Added .scaleMode decode options and context option to allows aspect fill thumbnail
#3628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fill thumbnail This is useful for user who want to use the aspect fill content mode on image view level to make image more sharp
…ible This still valid for old version cache because `.aspectFit` == `YES` == 1, and `.fill` == `NO` == 0
dreampiggy
commented
Oct 27, 2023
| @@ -57,7 +57,7 @@ + (instancetype)sharedCoder { | |||
| } | |||
|
|
|||
| #pragma mark - Bitmap PDF representation | |||
| + (UIImage *)createBitmapPDFWithData:(nonnull NSData *)data pageNumber:(NSUInteger)pageNumber targetSize:(CGSize)targetSize preserveAspectRatio:(BOOL)preserveAspectRatio { | |||
| + (UIImage *)createBitmapPDFWithData:(nonnull NSData *)data pageNumber:(NSUInteger)pageNumber targetSize:(CGSize)targetSize scaleMode:(SDImageScaleMode)scaleMode { | |||
There was a problem hiding this comment.
This effects https://github.com/SDWebImage/SDWebImagePDFCoder
Because that coder use this private API :)
dreampiggy
changed the title
.scaleMode decode options and context option to allows aspect fill thumbnail.scaleMode decode options and context option to allows aspect fill thumbnail
|
Decided to not support this feature. Which cause massive break changes (include SVG/PDF vector image) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
This is useful for user who want to use the aspect fill content mode on image view level to make image more sharp
This close #3622
Behavior Changes
.scaleModeoptions, it should always use the aspect fit instead..preserveAspectRatiooption for history compatible, until we reached v6.0.0SDThumbnailedKeyForKeychange arg from BOOL toNSUInteger, but this is binary compatible changes, and the thumbnail cache is still valid (because.aspectFit==YES== 1, and.fill==NO== 0)