-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image display deeper only on iOS 17.0 #3609
Comments
Provide a reproducable demo ? |
The code can reproducable: |
The thumbnail is useful, so actually you can not simple change that into If Apple's bug, you'be better fire radar for Apple: https://feedbackassistant.apple.com/ |
I try the follow Code (use avoidDecodedImage): CGSize thumbnailSize = CGSizeMake(100, 100); The behavior still the same |
Apple's Bug, not SDWebImage's issue. Fire radar to them :( |
A quick hack is to disable the thumbnail decoding (Do not pass that |
how to fix it |
@Hoony-HU If this is iOS system framework ImageIO bug, the only workaround is to disable using Using the Transformer: https://github.com/SDWebImage/SDWebImage/wiki/Advanced-Usage#image-transformer-50 This may workaround the issue. However, you MUST upgrade to v5.18.5+, that version contains a hacky workaround for full image decoding on PNG. https://github.com/SDWebImage/SDWebImage/releases/tag/5.18.5 |
Issue Info
Issue Description and Steps
Image display deeper only on iOS 17.0(and 17.0.1)
the code is:
CGSize thumbnailSize = CGSizeMake(100, 100);
[_imgView sd_setImageWithURL:[NSURL URLWithString:@"https://raw.githubusercontent.com/wgywgy/picTest/master/222.png"]
placeholderImage:nil
options:0
context:@{SDWebImageContextImageThumbnailPixelSize : @(thumbnailSize)}];
The problem code is in SDImageIOAnimatedCoder 269 line:
imageRef = CGImageSourceCreateThumbnailAtIndex(source, index, (__bridge CFDictionaryRef)[decodingOptions copy]);
It same like ios 17 change the implement. replace with:
imageRef = CGImageSourceCreateImageAtIndex(source, index, (__bridge CFDictionaryRef)[decodingOptions copy]);
The problem is gone.
The text was updated successfully, but these errors were encountered: