Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Release wake up lock when simulation is paused / allow user disable wake up lock #6703

Open
KawaiiZapic opened this issue Apr 22, 2024 · 2 comments · May be fixed by #6704
Open

[Feature Request] Release wake up lock when simulation is paused / allow user disable wake up lock #6703

KawaiiZapic opened this issue Apr 22, 2024 · 2 comments · May be fixed by #6704

Comments

@KawaiiZapic
Copy link

KawaiiZapic commented Apr 22, 2024 •
edited

Overview

When simulation is paused by any reason(F5 paused, controller not connected pop-up shown), release the wake up lock to allow system go to sleep and auto turn off screen.

And provide a option to disable wake up lock to customize this behavior.

Smaller details

None

Nature of request

UX improvement

Why would this feature be useful?

Ryujinx always holding wake up lock to prevent system fall into sleep even it's not necessary, this is waste of energy.
@nico-abram
Copy link
Contributor

nico-abram commented Apr 22, 2024 •
edited

Is this on windows? I assume this is the DisplaySleep thing implemented in https://github.com/Ryujinx/Ryujinx/pull/1850/files

@nico-abram nico-abram linked a pull request Apr 22, 2024 that will close this issue
Open
@nico-abram
Copy link
Contributor

@KawaiiZapic Could you check if #6704 works as intended? (A bot uploaded an artifact you can download)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't prevent windows Display Sleep while paused nico-abram/Ryujinx
2 participants
@nico-abram @KawaiiZapic