Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameter from onTakeX and onDropX methods #58

Open
DmitriyZaitsev opened this issue May 9, 2018 · 0 comments
Open

Remove parameter from onTakeX and onDropX methods #58

DmitriyZaitsev opened this issue May 9, 2018 · 0 comments
Assignees
Projects

Comments

@DmitriyZaitsev
Copy link
Contributor

Presenters have view and router properties available.
At the same time the callback methods onTakeView(v), onTakeRouter(r) have view and router as parameters.
Very often developers launch different async jobs in that methods and capture strong references to views. For minimizing the number of issues related to it, it's better to get rid of those parameters and access views only as presenter's properties.
Also, if you use Kotlin, the property access syntax is available forgetView() and getRouter(), so within the onTakeView you won't need to call this@MyPresenter.view.

@DmitriyZaitsev DmitriyZaitsev self-assigned this May 9, 2018
@DmitriyZaitsev DmitriyZaitsev added this to In Progress in RxViper May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
RxViper
In Progress
Development

No branches or pull requests

1 participant