Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Laplace approximation method #74

Open
ismailsenoz opened this issue Jan 6, 2022 · 3 comments
Open

Problems with Laplace approximation method #74

ismailsenoz opened this issue Jan 6, 2022 · 3 comments
Assignees

Comments

@ismailsenoz
Copy link
Contributor

There are couple of problems with the Laplace approximation:

  1. For Laplace approximation we use Optim.jl package to evaluate derivatives, however in current version of Optim.jl derivative syntax for 1D functions has changed leading to failures in ReactiveMP.jl.
  2. Current implementation of Laplace is not numerically stable.
@albertpod
Copy link
Member

This isn't the first time we suffer from optimization packages.
Should we use our handcrafted optimization procedures or we fix the version of optimization packages?
Your thoughts guys, @ismailsenoz @bvdmitri @ismailsenoz?

@bvdmitri
Copy link
Member

bvdmitri commented Jan 7, 2022

TBH I don't think we should use our handcrafted optimization procedures - maybe just another package? Or probably there is way to fix Optim.jl. There are plenty of other options too: GalacticOptim.

@albertpod
Copy link
Member

Related #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants